Ignore errorConversationEnded on end()

[orgads]

It is expected to be thrown there.

[orgads]

@ckkashyap Please review this.

[cwhitten]

Hi @orgads. Thank you for the pull request. Can you provide some information in the description explaining the motivations for the change and include steps to reproduce the error you're trying to avoid? Thank you.

[orgads]

I added an example to the commit message.

directLine.activity$
.filter(activity => activity.type === 'message')
.subscribe(
    message => {
      console.log("received message ", message)
      directLine.end();
    }
);

/.../node_modules/botframework-directlinejs/node_modules/rxjs/Subscriber.js:246
            throw err;
            ^
Error: conversation ended
    at Object.<anonymous> (/.../node_modules/botframework-directlinejs/built/directLine.js:47:30)
    at Module._compile (internal/modules/cjs/loader.js:689:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:700:10)
    at Module.load (internal/modules/cjs/loader.js:599:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:538:12)
    at Function.Module._load (internal/modules/cjs/loader.js:530:3)
    at Module.require (internal/modules/cjs/loader.js:637:17)
    at require (internal/modules/cjs/helpers.js:22:18)
    at Object.<anonymous> (/.../azure-bot.js:3:42)
    at Module._compile (internal/modules/cjs/loader.js:686:14)

[orgads]

ping?

[cwhitten]

Hi @orgads. We're evaluating the side effects of this change (and the issue you are trying to address with it) in our WebChat project here. We hope to land this soon. Thank you.

[cwhitten]

@orgads is it possible to inspect the the state of the connectionStatus observer to guard the call to next(...) instead of wrapping the call to next(...) in a try/catch?

Something like

if (this.connectionStatus$.getValue() !== ConnectionStatus.Ended) {
  this.connectionStatus$.next(ConnectionStatus.Ended);
}

[orgads]

What do you mean?

[cwhitten]

I edited my comment with an example of what I was thinking.

[orgads]

Oh, I see. I'll test it.

[orgads]

Doesn't help. You can easily try it yourself. I suppose you have a key. This is my test app:

global.XMLHttpRequest = require('xhr2');
global.WebSocket = require('ws');
const { DirectLine } = require('./built/directLine.js');
var directLine = new DirectLine({ secret: "<key>" });
directLine.activity$
.filter(activity => activity.type === 'message')
.subscribe(
    message => { console.log('ending...'); directLine.end(); }
);

[a-b-r-o-w-n]

@orgads thanks for your patience as we discuss this offline. We think that there may be a more comprehensive fix to this issue, but we plan on doing a major refactor away from rxjs in the future so this fix will suffice.

We will get this merged and published later today.

[orgads]

Thank you.

[a-b-r-o-w-n]

@orgads 0.11.0 has been published to npm.