Skip to content

Avoid retries when we get a 403 in websocket #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ckkashyap wants to merge 1 commit into from
Closed

Avoid retries when we get a 403 in websocket #126

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/directLine.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -697,13 +697,12 @@ export class DirectLine implements IBotConnection {
this.token = result.response.token;
this.streamUrl = result.response.streamUrl;
})
.map(_ => null)
.retryWhen(error$ => error$
.mergeMap(error => {
if (error.status === 403) {
// token has expired. We can't recover from this here, but the embedding
// website might eventually call reconnect() with a new token and streamUrl.
this.expiredToken();
return Observable.throw(errorExpiredToken);
}
return Observable.of(error);
})
Expand Down