Control Document Quotas for QuickPulse by rambhatt-msft · Pull Request #2425 · microsoft/ApplicationInsights-dotnet

rambhatt-msft · 2021-09-25T01:40:14Z

Fix Issue # .

Changes

(Please provide a brief description of the changes here.)

Checklist

I ran Unit Tests locally.
CHANGELOG.md updated with one line description of the fix, and a link to the original issue if available.

For significant contributions please make sure you have completed the following items:

Design discussion issue #
Changes in public surface reviewed

The PR will trigger build, unit tests, and functional tests automatically. Please follow these instructions to build and test locally.

Notes for authors:

FxCop and other analyzers will fail the build. To see these errors yourself, compile localy using the Release configuration.

Notes for reviewers:

We support comment build triggers
- /AzurePipelines run will queue all builds
- /AzurePipelines run <pipeline-name> will queue a specific build

tokaplan

Let's talk through this and do another round of changes.

WEB/Src/PerformanceCollector/PerformanceCollector/CollectionConfiguration.cs

...ceCollector/PerformanceCollector/Implementation/QuickPulse/Helpers/QuickPulseQuotaTracker.cs

...Collector/PerformanceCollector/Implementation/QuickPulse/QuickPulseCollectionStateManager.cs

WEB/Src/PerformanceCollector/PerformanceCollector/CollectionConfiguration.cs

WEB/Src/PerformanceCollector/PerformanceCollector/QuickPulseTelemetryProcessor.cs

...ollector/PerformanceCollector/Implementation/Service contract/CollectionConfigurationInfo.cs

WEB/Src/PerformanceCollector/PerformanceCollector/QuickPulseTelemetryModule.cs

…com/microsoft/ApplicationInsights-dotnet into rambhatt/adjustable-document-quotas

WEB/Src/PerformanceCollector/Perf.Tests/QuickPulse/QuickPulseTelemetryModuleTests.cs

WEB/Src/PerformanceCollector/PerformanceCollector/CollectionConfiguration.cs

...anceCollector/PerformanceCollector/Implementation/Service contract/QuotaConfigurationInfo.cs

tokaplan · 2021-10-26T00:30:25Z

WEB/Src/PerformanceCollector/PerformanceCollector/CollectionConfiguration.cs

                    {
-                        Tuple<float, float, float, float, float> initialQuotas;
-                        previousQuotasByStreamId.TryGetValue(documentStreamInfo.Id, out initialQuotas);
+                        previousQuotasByStreamId.TryGetValue(documentStreamInfo.Id, out Tuple<float, float, float, float, float> initialQuotas);


Let's rename initialQuotas in order to make it clear that it comes from the previous quota. Maybe previousQuotas or something like that.

The out var name.

...ceCollector/PerformanceCollector/Implementation/QuickPulse/Helpers/QuickPulseQuotaTracker.cs

tokaplan · 2021-10-26T00:38:33Z

...anceCollector/PerformanceCollector/Implementation/Service contract/QuotaConfigurationInfo.cs

@@ -0,0 +1,22 @@
+namespace Microsoft.ApplicationInsights.Extensibility.PerfCounterCollector.Implementation.Service_contract


In C#, namespace segments are PascalCase with no underscores or other special symbols. This should be ServiceContract

Nope, it's not old. The namespace is still called Service_contract.

WEB/Src/PerformanceCollector/PerformanceCollector/QuickPulseTelemetryProcessor.cs

tokaplan · 2021-10-26T18:45:07Z

...anceCollector/PerformanceCollector/Implementation/Service contract/QuotaConfigurationInfo.cs

@@ -0,0 +1,22 @@
+namespace Microsoft.ApplicationInsights.Extensibility.PerfCounterCollector.Implementation.Service_contract


Nope, it's not old. The namespace is still called Service_contract.

tokaplan · 2021-10-26T18:50:49Z

WEB/Src/PerformanceCollector/PerformanceCollector/CollectionConfiguration.cs

                    {
-                        Tuple<float, float, float, float, float> initialQuotas;
-                        previousQuotasByStreamId.TryGetValue(documentStreamInfo.Id, out initialQuotas);
+                        previousQuotasByStreamId.TryGetValue(documentStreamInfo.Id, out Tuple<float, float, float, float, float> initialQuotas);


The out var name.

WEB/Src/PerformanceCollector/PerformanceCollector/QuickPulseTelemetryModule.cs

…com/microsoft/ApplicationInsights-dotnet into rambhatt/adjustable-document-quotas

TimothyMothra · 2021-10-27T17:51:39Z

Please also update the Changelog under the VNext section. :)

TimothyMothra

LGTM. Please update changelog

rambhatt-msft and others added 10 commits August 27, 2021 14:55

save initial work

dd4d02b

add tests

afc3c60

save work

4e3cfde

save ongoing work

9e7e3db

end fix

611a71e

fix tests

9670e8e

Merge branch 'develop' into rambhatt/adjustable-document-quotas

bb0adf8

fix test errors

63d1e93

fix tests

e84bdc8

remove debug comments

ab499a2

tokaplan requested changes Sep 28, 2021

View reviewed changes

tokaplan reviewed Sep 28, 2021

View reviewed changes

...ollector/PerformanceCollector/Implementation/Service contract/CollectionConfigurationInfo.cs Show resolved Hide resolved

TimothyMothra reviewed Sep 28, 2021

View reviewed changes

WEB/Src/PerformanceCollector/PerformanceCollector/QuickPulseTelemetryModule.cs Outdated Show resolved Hide resolved

rambhatt-msft added 3 commits September 28, 2021 18:23

save PR comment fixes

4ab126e

add PR comment fix

2c98885

tiny fix

f0e4495

rambhatt-msft marked this pull request as ready for review September 29, 2021 18:10

rambhatt-msft added 2 commits September 29, 2021 12:36

add testcase

6ccf417

fix PR comments

486ff56

rambhatt-msft changed the title ~~[WIP] Control Document Quotas for QuickPulse~~ Control Document Quotas for QuickPulse Sep 29, 2021

rambhatt-msft and others added 10 commits September 29, 2021 13:26

Merge branch 'develop' into rambhatt/adjustable-document-quotas

74e5015

fix PR commit

de7c4c8

Merge branch 'rambhatt/adjustable-document-quotas' of https://github.…

0332166

…com/microsoft/ApplicationInsights-dotnet into rambhatt/adjustable-document-quotas

add PR fix

95af13a

fix compile

967ae19

add PR comment fix

736a360

Pr comment fix

f285561

save Pr comment fix

a6da204

save Pr comment

28e5734

fix PR

71873bc

Merge branch 'develop' into rambhatt/adjustable-document-quotas

308b9a4

TimothyMothra added this to the 2.20 milestone Oct 21, 2021

rambhatt-msft added 4 commits October 21, 2021 19:53

tentative changes for tests

cc8be6b

Merge branch 'rambhatt/adjustable-document-quotas' of https://github.…

48659d9

…com/microsoft/ApplicationInsights-dotnet into rambhatt/adjustable-document-quotas

fix tests

1c19688

fix tests

11fe028

rambhatt-msft force-pushed the rambhatt/adjustable-document-quotas branch from f6dfc7c to 11fe028 Compare October 25, 2021 22:19

save tests targeting

3880582

tokaplan requested changes Oct 26, 2021

View reviewed changes

fix Pr comments

4e7d2ca

tokaplan requested changes Oct 26, 2021

View reviewed changes

PR comments fixed

f4b8c22

tokaplan approved these changes Oct 26, 2021

View reviewed changes

Merge branch 'develop' into rambhatt/adjustable-document-quotas

99644c2

TimothyMothra reviewed Oct 27, 2021

View reviewed changes

WEB/Src/PerformanceCollector/PerformanceCollector/QuickPulseTelemetryModule.cs Show resolved Hide resolved

rambhatt-msft added 2 commits October 27, 2021 10:48

save PR fix

c4182bf

Merge branch 'rambhatt/adjustable-document-quotas' of https://github.…

2a3fd08

…com/microsoft/ApplicationInsights-dotnet into rambhatt/adjustable-document-quotas

TimothyMothra approved these changes Oct 27, 2021

View reviewed changes

TimothyMothra mentioned this pull request Oct 27, 2021

bump version 2.20-beta1 #2459

Merged

add changelog edit

ed0da2c

TimothyMothra merged commit 2c9b722 into develop Oct 27, 2021

TimothyMothra deleted the rambhatt/adjustable-document-quotas branch October 27, 2021 23:37

This was referenced Dec 22, 2025

Bump the production-dependencies group with 2 updates FokkoVeegens/PracticalDevOps#32

Merged

Bump Microsoft.ApplicationInsights.DependencyCollector from 2.12.0 to 2.23.0 Azure/durabletask#1292

Open

		@@ -0,0 +1,22 @@
		namespace Microsoft.ApplicationInsights.Extensibility.PerfCounterCollector.Implementation.Service_contract

Conversation

rambhatt-msft commented Sep 25, 2021

Changes

Checklist

Notes for authors:

Notes for reviewers:

Uh oh!

tokaplan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tokaplan Oct 26, 2021

Choose a reason for hiding this comment

Uh oh!

tokaplan Oct 26, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

tokaplan Oct 26, 2021

Choose a reason for hiding this comment

Uh oh!

rambhatt-msft Oct 26, 2021

Choose a reason for hiding this comment

Uh oh!

tokaplan Oct 26, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

tokaplan Oct 26, 2021

Choose a reason for hiding this comment

Uh oh!

tokaplan Oct 26, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

TimothyMothra commented Oct 27, 2021

Uh oh!

TimothyMothra left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants