Copy kindnet and kube-proxy assets to the upstream repository#76
Copy kindnet and kube-proxy assets to the upstream repository#76ggiguash merged 6 commits intomicroshift-io:mainfrom
Conversation
| %package kindnet | ||
| Summary: kindnet CNI for MicroShift | ||
| ExclusiveArch: x86_64 aarch64 | ||
| Requires: microshift = %{version} |
There was a problem hiding this comment.
Would that work?
| Requires: microshift = %{version} | |
| Requires: microshift = %{version} | |
| Conflicts: microshift-networking |
There was a problem hiding this comment.
This would not allow microshift-kindnet installation if microshift-networking is installed.
It may be a bit of too strong, I think, because Kindnet overrides and disables OVN-k.
Maybe, Obsoletes: is a better candidate? It'll cause the package to be uninstalled if present.
Since it's an uncharted territory, I can create a separate issue to follow-up, if you think we should do this.
| echo "Usage:" | ||
| echo "$(basename "$0") --verify OKD_URL RELEASE_TAG verify upstream release" | ||
| echo "$(basename "$0") --replace OKD_URL RELEASE_TAG replace microshift assets with upstream images" | ||
| echo "$(basename "$0") --verify OKD_URL RELEASE_TAG verify OKD upstream release" |
There was a problem hiding this comment.
Just btw. is there a reason why we split OKD_URL and RELEASE_TAG into two params even though we always join them later?
When it comes to OCI images I find this a bit superficial
There was a problem hiding this comment.
I think it's a mere convenience.
OKD_URL is fixed, while the tag is a variable that we calculate.
There was a problem hiding this comment.
I can create a follow-up issue if you think we should fix it
|
Now that the code has been removed from downstream repo, restarting the tests to see if we have not missed to copy anything upstream. Also, adjusting |
2 participants
Resolves #73
Resolves #75