Add a variety of type annotations for mypy#681
Merged
ianmcorvidae merged 9 commits intomeshtastic:masterfrom Oct 29, 2024
Merged
Add a variety of type annotations for mypy#681ianmcorvidae merged 9 commits intomeshtastic:masterfrom
ianmcorvidae merged 9 commits intomeshtastic:masterfrom
Conversation
Closed
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #681 +/- ##
==========================================
- Coverage 60.37% 60.35% -0.03%
==========================================
Files 24 24
Lines 3793 3811 +18
==========================================
+ Hits 2290 2300 +10
- Misses 1503 1511 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Contributor
|
Hi @william-stearns -- I went through and fixed the rest of the mypy complaints locally and pushed that up here. Sorry about the back and forth on this and thanks again for contributing! I'll get this merged now that CI is happy. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replacing #597 (I'm sure there's a more elegant way to do this.) Fixes a single missing "import io" in stream_interface.py