Reuse node to prevent overwriting channel settings#664
Merged
ianmcorvidae merged 1 commit intomeshtastic:masterfrom Sep 3, 2024
Merged
Reuse node to prevent overwriting channel settings#664ianmcorvidae merged 1 commit intomeshtastic:masterfrom
ianmcorvidae merged 1 commit intomeshtastic:masterfrom
Conversation
…r the admin channel
ianmcorvidae
approved these changes
Sep 3, 2024
Contributor
ianmcorvidae
left a comment
There was a problem hiding this comment.
This looks great to me. Should also remove a full cycle of requesting channels from these commands, not that they were working before anyway 😅
Contributor
|
(setting CI to run in case it finds anything that needs updating, but other than if it does, ready to merge I'd say) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #664 +/- ##
==========================================
+ Coverage 61.67% 61.68% +0.01%
==========================================
Files 24 24
Lines 3593 3594 +1
==========================================
+ Hits 2216 2217 +1
Misses 1377 1377
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
I noticed that I'm unable to use any
--ch-setsettings over the admin channel (using--dest). The core issue is that the repeated use ofinterface.getNodefetches all the channels again, overwriting the channels on the node object that had just been retrieved and updated to change the appropriate settings. This means thatdownlink_enabled,uplink_enabled, and so on couldn't actually be updated using remote admin. I've confirmed this change allowed me to change MQTT uplink/downlink on a remote node on a tall rooftop.I attempted to use
requestChannelsingetNodebut the repeated usage ofgetNodeitself blows away the channels on the object, regardless.