Don't automatically set the time from Python#663
Merged
ianmcorvidae merged 3 commits intomasterfrom Sep 5, 2024
Merged
Conversation
The Python MO is to do as little as possible beyond what the user has intentionally instructed. So don't try to set the time automatically.
Contributor
Author
|
Tangentially related to firmware/#4589 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #663 +/- ##
==========================================
- Coverage 61.67% 61.63% -0.05%
==========================================
Files 24 24
Lines 3593 3589 -4
==========================================
- Hits 2216 2212 -4
Misses 1377 1377
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
thebentern
approved these changes
Aug 30, 2024
Contributor
|
Seems alright to me. I'll merge it and add an extra commit to make |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Python MO is to do as little as possible beyond what the user has intentionally instructed. So don't try to set the time automatically.