Skip to content

Don't automatically set the time from Python#663

Merged
ianmcorvidae merged 3 commits intomasterfrom
outtatime
Sep 5, 2024
Merged

Don't automatically set the time from Python#663
ianmcorvidae merged 3 commits intomasterfrom
outtatime

Conversation

@jp-bennett
Copy link
Contributor

The Python MO is to do as little as possible beyond what the user has intentionally instructed. So don't try to set the time automatically.

The Python MO is to do as little as possible beyond what the user has intentionally instructed. So don't try to set the time automatically.
@jp-bennett
Copy link
Contributor Author

Tangentially related to firmware/#4589

@codecov
Copy link

codecov bot commented Aug 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.63%. Comparing base (bcce568) to head (5c312be).
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #663      +/-   ##
==========================================
- Coverage   61.67%   61.63%   -0.05%     
==========================================
  Files          24       24              
  Lines        3593     3589       -4     
==========================================
- Hits         2216     2212       -4     
  Misses       1377     1377              
Flag Coverage Δ
unittests 61.63% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ianmcorvidae
Copy link
Contributor

Seems alright to me. I'll merge it and add an extra commit to make --no-time a no-op (with just this change it'll still send a position, just not with a time). We can add a --set-time that uses the new admin command in 2.5+

@ianmcorvidae ianmcorvidae merged commit da30e11 into master Sep 5, 2024
@ianmcorvidae ianmcorvidae deleted the outtatime branch September 5, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants