Adds admin session_passkey handling for 2.5 remote admin#655
Adds admin session_passkey handling for 2.5 remote admin#655ianmcorvidae merged 1 commit into2.5from
Conversation
|
This looks good to me! Question, though -- do we need this for other admin "set" messages as well? |
Ah, yes. I suppose there is more to remote admin than just the config fields. You're correct, it will need to grab the key from those responses, and set it when sending those messages. |
jp-bennett
force-pushed
the
show-pubkey
branch
from
25b76d1 to
7839950
Compare
ianmcorvidae
left a comment
ianmcorvidae
left a comment
There was a problem hiding this comment.
Looks fine, I think! We should consolidate those two entries in the protocols dict but otherwise I think this is good. We still need to add the fetch session key bit you mentioned in discord, of course. I'll try to give that a look if someone else doesn't beat me to it
| portnums_pb2.PortNum.STORE_FORWARD_APP: KnownProtocol("storeforward", storeforward_pb2.StoreAndForward), | ||
| portnums_pb2.PortNum.NEIGHBORINFO_APP: KnownProtocol("neighborinfo", mesh_pb2.NeighborInfo), | ||
| portnums_pb2.PortNum.MAP_REPORT_APP: KnownProtocol("mapreport", mqtt_pb2.MapReport), | ||
| portnums_pb2.PortNum.ADMIN_APP: KnownProtocol( |
There was a problem hiding this comment.
I think this is just replacing it, but we should probably just add the handler to the existing entry for ADMIN_APP up on line 228
There was a problem hiding this comment.
Missed that it was already in there!
2 participants
Tested with a 2.5 node doing remote admin over pki with another 2.5 node, as well as a legacy admin against an older node. For completeness, probably should test this with a 2.4 local node as well.