Show two-way traceroute result with SNR if available#654
Merged
ianmcorvidae merged 1 commit intomeshtastic:2.5from Aug 25, 2024
Merged
Show two-way traceroute result with SNR if available#654ianmcorvidae merged 1 commit intomeshtastic:2.5from
ianmcorvidae merged 1 commit intomeshtastic:2.5from
Conversation
1 task
Contributor
|
I think this looks good and I'll get it into 2.5 now so we can squash anything CI might complain about. Thanks for this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: this is going towards the 2.5 branch.
If available, this shows the two-way traceroute result with SNR per hop. I left some comments for the validation, as it will likely serve as an example for other clients as well.
Also added a bool
isDestto_nodeNumToId()(which defaults toTrue) to distinguish between the broadcast address, which is always a destination, and an unknown node in a traceroute.