Conversation
5075b6a to
6db69b6
Compare
|
I don't see the Reconnect EHR button, do we need to add it back? |
|
Can we make the buttons in the Task Management tab all the same height? |
Author
f0586b3 to
c145188
Compare
jtquach1
reviewed
Feb 20, 2024
avirgulto
reviewed
Feb 21, 2024
jtquach1
reviewed
Feb 22, 2024
jtquach1
left a comment
There was a problem hiding this comment.
I forgot to comment on these files (there's some redundant code)
jtquach1
requested changes
Feb 22, 2024
jtquach1
requested changes
Feb 22, 2024
jtquach1
left a comment
There was a problem hiding this comment.
realized I did not check on the Task UI, but I think the styling looks good to me with one minor suggestion
jtquach1
approved these changes
Feb 23, 2024
e0ed32b to
772615f
Compare
avirgulto
approved these changes
Feb 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Describe your changes
This PR includes a lot of changes to the request generator, including the tickets' original goal of creating a UI to view/manage tasks. Actually being able to interact with the tasks will be handled in a different ticket.
I've also overhauled the UI to support several different views, instead of modals for everything, since we'd be entering the territory of modals inside modals continuing on the path we were on. The settings have been made a separate tab and I've rewritten the component to use react hooks.
The app now supports a top down context using react's
useContext, which means that components can now access and update a 'global' state instead of passing information down through props and changes back up through callbacks. This can be used in the future for other variables that need to be available to the whole app.Issue ticket number and Jira link
REMS-605
Checklist before requesting a review
devnot main (the only exception to this is releases fromdevand hotfix branches)Checklist for conducting a review