Fixed improper demorgans-law case logic for logger warning#173
Merged
dmendelowitz merged 2 commits intodevelopfrom Jan 10, 2022
Merged
Fixed improper demorgans-law case logic for logger warning#173dmendelowitz merged 2 commits intodevelopfrom
dmendelowitz merged 2 commits intodevelopfrom
Conversation
Dtphelan1
requested review from
dmendelowitz,
jafeltra,
julianxcarter and
mgramigna
as code owners
Contributor
dmendelowitz
left a comment
dmendelowitz
left a comment
There was a problem hiding this comment.
The logic looks good but, is there any reason we aren't just checking they type of notification info to be boolean? Seems a little more fool proof
Contributor
Author
This lateral thinking is why we do PR's. Yeah that would be way freaking easier. I'll swap now. |
dmendelowitz
approved these changes
Jan 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Logic is hard