Merged
Conversation
julianxcarter
requested review from
Dtphelan1,
dmendelowitz,
jafeltra and
mgramigna
as code owners
Contributor
dmendelowitz
left a comment
dmendelowitz
left a comment
There was a problem hiding this comment.
This works great! I just had one tiny comment about some wording
| if (!(adverseEventCode && effectiveDate && grade)) { | ||
| throw new Error('The adverse event is missing an expected attribute. Adverse event code, effective date, and grade are all required.'); | ||
| } else if (functionCode && !actor) { | ||
| throw new Error('The adverse event is missing an expected attribute. Adverse event actor is a required element within the Participation extension'); |
Contributor
There was a problem hiding this comment.
This error message kind of makes it feel like actor is 100% required, not just conditionally required. I wonder if there's a better way to word it? Like would someone necessarily know what the participation extension is if they're just dumping a CSV into the client?
Contributor
Author
There was a problem hiding this comment.
This is a really good point. I've changed this message to be a little more specific about the relationship between the actor and functionCode columns.
dmendelowitz
approved these changes
Dec 17, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the Participant extension to the CTC AE extractor.
New behavior
The CTC AE extractor extractors two new values (
actorandfunctionCode) that make up the two pieces of the Participant complex extension. IffunctionCodeis included,actormust be included as well per the Ig.Code changes
docsandsample-client-data. New fields referenced in theCSV_Templatessheet as well.valueSetsdirectory for use in fetching display values for thefunctionCodecolumn.Testing guidance
Ensure tests pass and extracted data looks good.