CSVExtractors support dataDirectory & fileName arguments#170
Merged
CSVExtractors support dataDirectory & fileName arguments#170
Conversation
julianxcarter
requested changes
Dec 15, 2021
Contributor
julianxcarter
left a comment
There was a problem hiding this comment.
This looks great and I think the approach makes a lot of sense! I just have a few suggestions that I'd like your thoughts on :).
julianxcarter
approved these changes
Dec 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CSVExtractors now support ingesting a
dataDirectory&fileNameargument pair, with which the extractor constructs an absolute path to a data file. This technique for specifying the location of a CSV file on disk is now the preferred method, in contrast with our previousfilePathargument technique. Documentation, example config files, and schemas have been updated to reflect this.New behavior
All CSVExtractors extending from the BaseCSVExtractor should now support the ingestion of
fileNameanddataDirectoryarguments. The BaseCSVExtractor now considers a new case in the initial extractor construction to handle the consumption of these arguments.Code changes
dataDirectoryis not an absolute path;dataDirectoryandfileNamearguments to theirsuperconstructors;BaseCSVExtractorto the extractors exported byMEF/src/extractors/index.js;Testing guidance