Changing notificationInfo schema for easier use in UI#160
Merged
julianxcarter merged 1 commit intodevelopfrom Oct 14, 2021
Merged
Changing notificationInfo schema for easier use in UI#160julianxcarter merged 1 commit intodevelopfrom
julianxcarter merged 1 commit intodevelopfrom
Conversation
julianxcarter
approved these changes
Oct 14, 2021
Contributor
julianxcarter
left a comment
There was a problem hiding this comment.
Works well! I can confirm that validation of the notificationInfo section of the config in the MEF still works fine, and also that this addresses the notificationInfo always being required in the Extraction UI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Allow notificationInfo to be empty and with the required fields only being required if any other field is present.
New behavior
Required fields for notificationInfo are now dependencies in the schema, meaning they are only required if other fields are present. This allows for notificationInfo to be on the config editor page of the extraction UI but not have to be filled out.
Code changes
notificationInfoinconfig.schema.jsonchanged to be dependencies insteadapp.jsto make sure the notificationInfo is not empty before trying to send a notificationTesting guidance