Better logging in the CSVURLModule #141
Merged
dmendelowitz merged 4 commits intodevelopfrom Jul 20, 2021
Merged
Conversation
Contributor
dmendelowitz
left a comment
There was a problem hiding this comment.
This looks good to me! Just had one minor comment
dmendelowitz
approved these changes
Jul 15, 2021
jafeltra
reviewed
Jul 16, 2021
Contributor
jafeltra
left a comment
There was a problem hiding this comment.
The changes here make sense and I get the appropriate log messages. I have one broader question that I'm not sure if was discussed previously or not.
jafeltra
reviewed
Jul 19, 2021
Co-authored-by: Julia Afeltra <30803904+jafeltra@users.noreply.github.com>
jafeltra
approved these changes
Jul 19, 2021
Contributor
jafeltra
left a comment
There was a problem hiding this comment.
Thanks for making those changes!
Contributor
|
@dmendelowitz do you still approve with the minor changes made since you last approved? Just wanted to give you a chance to take a look before I merged! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses STEAM-670: 'CSVURLModule should validate the the URL it receives is a valid URL'. Upon closer inspection, it doesn't look like we do the level of validation we expected in the CSVFileModule. Accordingly, all this task takes up is better logging in fillDataCache logic.
New behavior
When a URL is provided that cannot be used successfully in CSV extraction, error messages are logged to the console. Additionally, debug messages have been added throughout the
fillDataCacheroutine.Code changes
fillDataCachefunction.Testing guidance
Below is an example (courtesy of @julianxcarter ) of a valid URL extractor config
{ "label": "cancerDiseaseStatus", "type": "CSVCancerDiseaseStatusExtractor", "constructorArgs": { "url": "https://raw.githubusercontent.com/mcode/mcode-extraction-framework/main/test/sample-client-data/cancer-disease-status-information.csv" } }