Adding custom schema format for comma separated emails#138
Merged
julianxcarter merged 2 commits intodevelopfrom Jul 1, 2021
Merged
Adding custom schema format for comma separated emails#138julianxcarter merged 2 commits intodevelopfrom
julianxcarter merged 2 commits intodevelopfrom
Conversation
Contributor
Author
|
Also, I sort of just assumed it would be a good thing to strip excess whitespace, but does anyone actually know if notificationInfo.to needs to be strictly commas with no spaces? |
Dtphelan1
reviewed
Jul 1, 2021
Dtphelan1
approved these changes
Jul 1, 2021
Contributor
Dtphelan1
left a comment
There was a problem hiding this comment.
This looks good. Tested with both an array of strings and a single string with multiple, commas-separated emails and things look good. Great work!
julianxcarter
approved these changes
Jul 1, 2021
Contributor
julianxcarter
left a comment
There was a problem hiding this comment.
Validation works flawlessly for me, both within the array and also in a comma-separated string. Nice work!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adding a custom format to the config validator that checks if a string has the format of emails separated by commas, for example:
whoever@whatver.com,somone@wherever.com. This new format is used to validate thenotificationInfo.tofield in the configNew behavior
The config validator will now ensure that the
notificationInfo.tofield of the config is either an array of emails or a string of emails separated by commasCode changes
comma-separated-emails, added toconfigValidator.jswhich splits a string at any commas, strips excess whitespace and then validates the resulting strings against Ajv's email format regexconfig.schema.jsonupdated to usecomma-separated-emailsfornotificationInfo.toTesting guidance
Here are some variations to test:
test@example.coma single email should still be validtest#example.coma single invalid email should not be validtest@example.com,example@test.comemails separated by comma should be validtest@example.com,demo&example.comshould not be valid if any item is not a valid email