Conversation
dmendelowitz
requested review from
Dtphelan1,
jafeltra,
julianxcarter and
mgramigna
as code owners
|
|
||
| function validateConfig(config) { | ||
| const valid = validator.validate('config', config); | ||
| const errors = ajv.errorsText(validator.errors, { dataVar: 'config' }); |
Contributor
There was a problem hiding this comment.
I did not realize there was a way to access errors from the base Ajv object, good find!
julianxcarter
approved these changes
Jun 25, 2021
Contributor
julianxcarter
left a comment
julianxcarter
left a comment
There was a problem hiding this comment.
This works as intended and looks great to me
mgramigna
reviewed
Jun 28, 2021
| function checkInputAndConfig(config, fromDate, toDate) { | ||
| // Check input args and needed config variables based on client being used | ||
| const { patientIdCsvPath } = config; | ||
| validateConfig(config); |
Contributor
There was a problem hiding this comment.
I think it might be useful to have some (likely debug level?) log statements here to indicate that this is happening/has succeeded after the function call
Contributor
|
Made a tiny comment but everything about the functionality/tests looks good to me |
mgramigna
approved these changes
Jun 28, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The config file is now checked for errors by validating it against the new config schema
New behavior
When there are one or more errors in the config file, the client will fail and tell the user what is wrong with their config file
Code changes
configValidator.jscontains the newvalidateConfig()function that performs validationcheckInputAndConfig()inapp.jsnow calls the newvalidateConfig()function instead of manually checking forpatientIdsCsvPathapp.test.jsto work with the new validatorconfigValidator.test.jsTesting guidance