Update csv config schema to include all properties

[mgramigna]

Summary

Fill out the rest of the JSON schema for CSV config

New behavior

N/A

Code changes

Add all properties and some required ones to JSON Schema

Testing guidance

here is a URL with the updated JSON schema loaded into the validator.

Play around with this, paste your config in, delete some properties, invalid data type stuff, etc.

A visual inspection of the schema is also a good idea, it's not too dense

[Dtphelan1]

DP2 - I think we could also use a commonExtractorArgs that defines an object with a baseFhirUrl property of type string with and format hostname

[mgramigna]

DP2 - I think we could also use a commonExtractorArgs that defines an object with a baseFhirUrl property of type string with and format hostname

Clarifying Q: we make use of commonExtractorArgs with the URL properties (including auth and such) in other "proprietary" versions of the mcode-extraction-framework. Does that property also apply to CSV config? Since the schema I made is pretty specific to that.

[mgramigna]

DP2 - I think we could also use a commonExtractorArgs that defines an object with a baseFhirUrl property of type string with and format hostname

Clarifying Q: we make use of commonExtractorArgs with the URL properties (including auth and such) in other "proprietary" versions of the mcode-extraction-framework. Does that property also apply to CSV config? Since the schema I made is pretty specific to that.

Kind of answered my own question. Looks like we do parse/use commonExtractorArgs in the base apps so I will include a simple version of that in the schema

[jafeltra]

This looks good! I had a couple minor comments and a couple general questions.

[jafeltra]

This looks good to me! All my questions were addressed or made into jira tasks. I'm approving since I'll be out tomorrow, but happy to be a part of any conversations about the comments from Dylan on Thursday if you wait until then to discuss!

[Dtphelan1]

After responding to my comments and addressing Jules' comments, this looks good to me. Great work Matt 😄