Add test for Patient Id CSV with BOM#131
Merged
Conversation
jafeltra
requested review from
Dtphelan1,
dmendelowitz,
julianxcarter and
mgramigna
as code owners
mgramigna
approved these changes
Jun 16, 2021
Contributor
mgramigna
left a comment
mgramigna
left a comment
There was a problem hiding this comment.
Confirmed that tests pass/look good. Confirmed that fixture CSV has BOMs. 10/10
Dtphelan1
approved these changes
Jun 18, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds new test to ensure
parsePatientIdsproperly handles CSVs with BOMs.New behavior
None
Code changes
New test and fixture file
Testing guidance
The new test should pass. Removing the
bom: trueoption from theparseinparsePatientIdswill cause the new test to fail, and adding it back will let it pass.