Conversation
…de to write to file to cli.js
mgramigna
suggested changes
Jun 3, 2021
Contributor
|
I see there are some linter errors being caught by Github actions here. We have a pretty strict linter set up in the MEF, which allows us to enforce code style and make sure the syntax is correct. You can configure VS Code to show you the lint errors by installing this extension: https://marketplace.visualstudio.com/items?itemName=dbaeumer.vscode-eslint Once you do, you should see some errors in the editor that should need to be resolved. You can also check lint locally with the npm script we've added: We also have a command that will fix and automatically fixable lint issues: |
Contributor
|
Other than the lint errors and the change request I made, this looks good and works as expected |
mgramigna
approved these changes
Jun 3, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The function mcodeApp in src/cli/app.js was modified to return the extractedData object instead of writing the results to a file. src/cli/cli.js was modified to write the results of calling mocdeApp to a file.
New behavior
cli.js writes the results of extraction to a file instead of app.js.
Code changes
The code to write to a file was moved from app.js to cli.js and replaced with a return statement.
Testing guidance
Use 'npm start' to run extraction.