Add helper for parsing patient CSV ids with BOMs#124
Merged
Conversation
Contributor
|
lol the |
Contributor
|
Otherwise I think this looks plenty good and you should consider this conditionally approved by me. HAGS 🏖 |
Contributor
Author
Dtphelan1
approved these changes
May 28, 2021
dmendelowitz
reviewed
Jun 1, 2021
Contributor
dmendelowitz
left a comment
There was a problem hiding this comment.
This looks good to me, I just had one small comment.
dmendelowitz
approved these changes
Jun 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Add a re-usable helper in a new
appUtilsfile that parses a provided CSV path formrncolumn to iterate through patient IDs during extraction.I want to make sure the approach for this is solid before putting up a bunch of PRs on other repos.
New behavior
None
Code changes
index.jsexportsapp.jsto use new helperTesting guidance
Run usual checks and extraction. Output should be the same as it was prior, as we should be getting the same MRNs as before.