Improve checking for default log file#123
Merged
julianxcarter merged 1 commit intodevelopfrom May 26, 2021
Merged
Conversation
dmendelowitz
requested review from
Dtphelan1,
jafeltra,
julianxcarter and
mgramigna
as code owners
jafeltra
approved these changes
May 21, 2021
Contributor
jafeltra
left a comment
jafeltra
left a comment
There was a problem hiding this comment.
This makes sense to me! I tested in a similar case to where this was first discovered, and that seemed to be resolved (🥁) as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Previously, the check for the default log file used a strict equality looking for the value
/logs/run-logs.json, but now the paths compared will be resolved to allow for different but functionally equivalent paths like./logs/run-logs.jsonor../mcode-extraction-framwork/logs/run-logs.json, etc.New behavior
The
checkLogFile()function inapp.jsnow uses resolved paths to check for the default log file.Code changes
checkLogFile()inapp.jsupdated with the change described aboveTesting guidance
To test this, starting with no default log file, the following commands should produce the same logs folder and file in the default location:
npm start -- -e -f 01-01-2019 -t 01-01-2021 -r ../mcode-extraction-framework/logs/run-logs.jsonnpm start -- -e -f 01-01-2019 -t 01-01-2021