Adding references to FHIR Resources in CSV_Templates#111
Merged
Conversation
dmendelowitz
requested review from
Dtphelan1,
jafeltra,
julianxcarter and
mgramigna
as code owners
Contributor
|
This looks great! I think the one link I'd recommend updating is the one in CancerPatient. The other links use the released STU1 mCODE links, rather than the |
Contributor
julianxcarter
left a comment
julianxcarter
left a comment
There was a problem hiding this comment.
All of these changes look good to me, apart from the CancerPatient sheet that @jafeltra referenced. We should also probably delete that ~$CSV_Templates.xlsx file that was saved as well. Every time you make a change to the file excel will auto-save that to the repo, so we'll need to manually delete it before the next commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Each sheet in the CSV_Templates excel file now links to pages with information on relevant FHIR resources to that csv template
Testing guidance
Check that the links on each sheet are the correct and make sure I didn't leave any out. Also let me know if you have issues with the formatting, I based it on what was already there in the Adverse Event sheet.