Make ISO 8601 Timestamp milliseconds support optional#352
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a build switch
MO_ENABLE_TIMESTAMP_MILLISECONDSto enable / disable the millisecond support of the Timestamp class.To enable, set
MO_ENABLE_TIMESTAMP_MILLISECONDS=1(disabled by default). To keep the old behavior, disable the switch explicitly in the build settings.If disabled, the milliseconds fraction of incoming ISO 8601 timestamps will be ignored. Outgoing ISO 8601 strings will omit the milliseconds.
This change saves a few bytes per Timestamp, with the class size being slightly reduced from 24B to 20B. While this ~17% saving is not too significant, it nevertheless fits the design philosophy of microcontroller optimization.