Merged
Conversation
From the OCPP Spec: > The Charge Point SHOULD NOT send StatusNotification.req PDUs for > historical status change events that happened while the Charge > Point was offline. So, each time we queue another StatusNotification, we drop the StatusNotifications already in the queue for that connector.
Setting them to inOperative causes the status to change to Unavailable. The OCPP Test Spec and OCTT requires the Status to change to Finishing when a Reset has been recieved.
Should allow an ID Tags with the same parent ID Tag to start/stop transactions together. - Associate parent ID Tag with a transaction if known. - If a transaction is underway, and an ID tag is swiped which doesn't match the one that started the transaction, then submit an Authorize request. - If the Authorize request is accepted, and if it contains a matching parent ID tag with the transaction, then end the transaction.
According to the test spec, you need to return Rejected if you don't support DataTransfer. Returning Unimplemented is not valid.
Interval duration configuration should not be allowed to be set to negative values, according to the spec.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains fixes for passing the OCTT test cases. A big shout out to @heakins who contributed back the patches to MicroOCPP!
For more information on the fixed issues, see the detailed commit messages.
The fixes addressing the rejection of SendLocalList, GetLocalListVersion and UnlockConnector have already been superseded on main. To disable Local Authorization Lists, set the build flag
MO_ENABLE_LOCAL_AUTH=0. The connector lock support is already disabled by default.