Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce a new function
getChargePointStatus()in the C/C++ API which returns the OCPP field ChargePointStatus as reported via StatusNotification.Furthermore, this PR changes the scoped enum ChargePointStatus in namespace MicroOcpp to a C-style enum not lying in a namespace. This could break your integration if you fetched the ChargePointStatus over the Connector class (and going beyond the API). To upgrade, the following changes are necessary:
MicroOcpp::ChargePointStatus myStatus;-->ChargePointStatus myStatus;MicroOcpp::ChargePointStatus::Available-->ChargePointStatus_AvailableMicroOcpp::ChargePointStatus::NOT_SET-->ChargePointStatus_UNDEFINEDThis refactoring step is part of the changes to make C integrations easier. All enums which could be relevant to the firmware integration will be changed to C-style enums.