Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Optimize the firmware footprint of the MO_DBG_X macros.
The MO_DBG_X functionality was implemented inside macros only. This approach leads to much duplicated code after preprocessing. This PR moves a large share of the MO_DBG_X functionality into actual C++ functions. A simple measurement for validation showed a significant firmware footprint decrease of ~30 kB.
If using a custom console integration (enabled via
MO_CUSTOM_CONSOLE=1), theMO_CONSOLE_PRINTFmacro also comes at a significant overhead. By moving the message buffer which is allocated on the heap into the data section, the firmware size decreases by further ~10 kB.