Updates to Isochrone API #1596
Merged
Updates to Isochrone API #1596
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cafesilencio
force-pushed
the
sb-3734-update-isocrone-services
branch
7 times, most recently
from
1650d25 to
6eb36b2
Compare
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #1596 +/- ##
============================================
+ Coverage 77.93% 78.03% +0.09%
Complexity 1066 1066
============================================
Files 158 158
Lines 4450 4493 +43
Branches 617 630 +13
============================================
+ Hits 3468 3506 +38
Misses 714 714
- Partials 268 273 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
|
LukasPaczos
reviewed
Sep 27, 2024
Comment on lines
253
to
254
| public Builder addContoursMeters(@NonNull @IntRange(from = 0, to = 100000) | ||
| Integer... listOfMeterValues) { |
Contributor
There was a problem hiding this comment.
Suggested change
| public Builder addContoursMeters(@NonNull @IntRange(from = 0, to = 100000) | |
| Integer... listOfMeterValues) { | |
| public Builder addContoursMeters(@NonNull Integer... listOfMeterValues) { |
Let's not add the integer range, this range can be dynamically changed on the backend.
Comment on lines
245
to
246
| * must be in increasing order. The maximum distance that can be specified | ||
| * is 100000 meters (100km). |
Contributor
There was a problem hiding this comment.
Suggested change
| * must be in increasing order. The maximum distance that can be specified | |
| * is 100000 meters (100km). | |
| * must be in increasing order. The default maximum distance that can be specified | |
| * is 100000 meters (100km), if you need a bigger range contact support. |
Comment on lines
278
to
279
| * increasing order. The maximum distance that can be specified | ||
| * is 100000 meters (100km). |
Contributor
There was a problem hiding this comment.
Suggested change
| * increasing order. The maximum distance that can be specified | |
| * is 100000 meters (100km). | |
| * increasing order. The default maximum distance that can be specified | |
| * is 100000 meters (100km), if you need a bigger range contact support. |
cafesilencio
force-pushed
the
sb-3734-update-isocrone-services
branch
from
6eb36b2 to
6e918f2
Compare
cafesilencio
force-pushed
the
sb-3734-update-isocrone-services
branch
from
6e918f2 to
93a3561
Compare
Zayankovsky
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added updates to Isochrone API to support new features like driving-traffic profile, contours_meters, road/route exclusions and departure date/time.