Add pacparser_setmyip_from_host function#36
Closed
DrDaveD wants to merge 1 commit intomanugarg:masterfrom
Closed
Conversation
Author
|
@manugarg, I merged my pull request so it is now up to date. Can you please take another look at this contribution and tell me what you suggest? We were discussing it by email a year ago but never came to a resolution. I need to move forward with getting pacparse.c and pacwget included as we have discussed in the past. If you don't want this extra function in the library, I can move it back to pacparse.c. You had suggested making some kind of contrib area, but if pacparse.c is already included in the package, maybe that's good enough and it's easier. Please let me know what you want me to do. |
DrDaveD
force-pushed
the
setmyip_from_host
branch
from
0f1dbca to
529d2af
Compare
Author
|
Too much trouble to fix something that's probably never going to be merged anyway, closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my suggested solution to issue #25.
Manu, I know you have expressed some reservations via email, let's please discuss here what your current specific proposal is and get this resolved.