Skip to content

[Snyk] Fix for 2 vulnerabilities#162

Open
maniator wants to merge 1 commit intonextfrom
snyk-fix-ef1609ecbfea945a0a1b5d27988687af
Open

[Snyk] Fix for 2 vulnerabilities#162
maniator wants to merge 1 commit intonextfrom
snyk-fix-ef1609ecbfea945a0a1b5d27988687af

Conversation

@maniator
Copy link
Owner

@maniator maniator commented Feb 4, 2026

snyk-top-banner

Snyk has created this PR to fix 2 vulnerabilities in the npm dependencies of this project.

Snyk changed the following file(s):

  • examples/preact/package.json

Vulnerabilities that will be fixed with an upgrade:

Issue Score
medium severity Regular Expression Denial of Service (ReDoS)
SNYK-JS-DIFF-14917201
  708  
medium severity Uncontrolled Recursion
SNYK-JS-ESLINT-15102420
  623  

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Regular Expression Denial of Service (ReDoS)

Copilot AI review requested due to automatic review settings February 4, 2026 12:33
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates example app dependencies to remediate Snyk-reported vulnerabilities in diff and eslint/jest by bumping specific versions in the Preact example’s package.json.

Changes:

  • Upgrade eslint in examples/preact/package.json from 5.12.0 to 9.26.0 to address a reported vulnerability.
  • Upgrade jest in examples/preact/package.json from 23.6.0 to 24.0.0 to address a reported vulnerability.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

"dotenv": "6.0.0",
"dotenv-expand": "4.2.0",
"eslint": "5.12.0",
"eslint": "9.26.0",
Copy link

Copilot AI Feb 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upgrading eslint to 9.26.0 while keeping eslint-config-react-app at ^3.0.8 introduces a major-version mismatch with the config's expected ESLint peer dependency (it was designed for the ESLint 5-era CRA toolchain), which can lead to unsupported or failing lint runs. To avoid breaking the example's linting, consider either upgrading the entire React App ESLint stack (config plus related plugins) to versions compatible with ESLint 9, or limiting the eslint upgrade to a supported major for the existing config and addressing the vulnerability via a different remediation strategy.

Suggested change
"eslint": "9.26.0",
"eslint": "^5.16.0",

Copilot uses AI. Check for mistakes.
"html-webpack-plugin": "4.0.0-alpha.2",
"identity-obj-proxy": "3.0.0",
"jest": "23.6.0",
"jest": "24.0.0",
Copy link

Copilot AI Feb 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing jest to 24.0.0 while leaving related Jest ecosystem packages (e.g. babel-jest at 23.6.0 and jest-resolve at 23.6.0) on the previous major is inconsistent with Jest's versioning model, where these packages are expected to be kept in lockstep, and may cause test runner or transform issues in this example app. It would be safer to either upgrade the full Jest stack (core plus babel-jest, jest-resolve, etc.) to matching versions, or keep jest on the existing major and use an alternative mitigation for the reported vulnerability.

Suggested change
"jest": "24.0.0",
"jest": "23.6.0",

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants