This repository was archived by the owner on Jun 3, 2024. It is now read-only.
Operations: transform CloneOperation back to simple static method#75
Open
antis81 wants to merge 1 commit intodevelopmentfrom
Open
Operations: transform CloneOperation back to simple static method#75antis81 wants to merge 1 commit intodevelopmentfrom
antis81 wants to merge 1 commit intodevelopmentfrom
Conversation
9403b11 to
0dd6ad5
Compare
Member
Author
|
@scunz Does this match to what you have in mind concerning the "service infrastructure"? |
Member
|
Yes, just running the clone without any threading is fine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@scunz Can you please review and confirm, that this matches your imagination? If so, I'll go on transforming the former CloneOperation, preparing it for our planned MGV-Service.
Things to do after the above is confirmed:
Git::CloneOperationgit_clone_optionsto publicGit::CloneOptions, making them available to the public APIGit::CloneOperation::setSomeCloneOptionmethods have to be extracted into a new publicGit::CloneOptionsclass or struct.