Added French layout - Passed selector value to Keyboard function. ow is possible to type a character where the cursor is located instead at the end of the selected field#6
Merged
11 commits merged intomasterfrom Jan 12, 2016
unknown repository
Merged
Added French layout - Passed selector value to Keyboard function. ow is possible to type a character where the cursor is located instead at the end of the selected field#611 commits merged intomasterfrom unknown repository
11 commits merged intomasterfrom
unknown repository
Conversation
ghost
changed the title
Author
|
Now is possible to type a character where the cursor is located instead at the end of the selected field |
ghost
closed this
ghost
changed the title
ghost
reopened this
Owner
There was a problem hiding this comment.
@worgock thank you a lot for the attention to this project. I'm really sorry that now i don't have enough time to commit to this project. I added you as contributor to the project and I think it would be fair to allow you commit without my special attention.
Only one comment regarding this PR is that maybe you can clean-up a code little bit and remove commented out code if it's not needed as also console.log debugging.
And thank you one more time 👍
ghost
pushed a commit
that referenced
this pull request
Jan 12, 2016
Added French layout - Passed selector value to Keyboard function. Now is possible to type a character where the cursor is located instead at the end of the selected field
ghost
merged commit
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have added the french layout. I have also updated the example and advance tutorial.
I have changed base.js and keyboard.js passing selector value because when there are multiple input nodes there is an issue on $current_input.