Open
Conversation
Contributor
|
Hey, thanks for the PR! I can certainly see the point of this, but I'm a little worried that we'll forget to keep it in sync in the future. @m-ou-se: What do you think? |
Author
|
If keeping all the features in sync is a worry I would, at minimum, recommend forwarding the |
m-ou-se
force-pushed
the
master
branch
2 times, most recently
from
8ec0e98 to
635617f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to allow users to directly control the features of the pyo3 instance used by inline-python without adding it as a direct dependency (and thus risking the versions of pyo3 drifting out of date without pinning both libraries versions). This is especially useful as inline-python re-exports pyo3.
The format used is "pyo3-{featurename}", following the kebab case of pyo3's features.