Fix ordering of adding long press gesture recognizer#24
Merged
lxcid merged 1 commit intolxcid:masterfrom May 2, 2013
jhersh:master
Merged
Fix ordering of adding long press gesture recognizer#24lxcid merged 1 commit intolxcid:masterfrom jhersh:master
lxcid merged 1 commit intolxcid:masterfrom
jhersh:master
Conversation
|
indeed, I got the same crashes when popping the collectionview from the view hierarchy. I fixed it in my branch but won't send a pull request as you've already done so ;-) |
lxcid
added a commit
that referenced
this pull request
May 2, 2013
Fix ordering of adding long press gesture recognizer
Owner
|
Thanks for the fix guys. This should have been merge in much earlier. Sorry for the delay! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm seeing repeatable crashes upon
deallocin theUILongPressGestureRecognizerassociated with LXReorderableCollectionViewFlowLayout.I believe this stems from the order in which LXReorderableCollectionViewFlowLayout sets up its gesture recognizers on the collection view in
setupCollectionView.Specifically, my collection view does not have a default long press gesture recognizer, so when
setupCollectionViewcalls-requireGestureRecognizerToFailto attach it to the default long press recognizer, it actually ends up requiring itself to fail and thusly (I'd guess) prevents itself from being deallocated.The fix is simple: don't add the new long press gesture recognizer to the collection view until after any other
-requireGestureRecognizerToFaildependencies are set up.