Skip to content

fix for LDEV-640#30

Open
clitnak wants to merge 1 commit intolucee:masterfrom
MasterControlIncPublic:LDEV-640
Open

fix for LDEV-640#30
clitnak wants to merge 1 commit intolucee:masterfrom
MasterControlIncPublic:LDEV-640

Conversation

@clitnak
Copy link
Copy Markdown

@clitnak clitnak commented Nov 20, 2015

This looks like a big change but it is a lot of whitespace.

@bdw429s
Copy link
Copy Markdown

bdw429s commented Nov 20, 2015

Use this URL to hide whitespace in the diff
https://github.com/lucee/Lucee4/pull/30/files?w=1

@micstriit
Copy link
Copy Markdown
Contributor

we can not make that change, because this changes how scheduled tasks are working. let say you have a scheduled task that runs every minute and takes 90 seconds to execute, maybe you still expect that it runs every minutes even there are always 2 running at time. because you need the result of the scheduled task to be as fresh as possible. if we do a change like this we need a flag in the admin for this like "[x] skip if the previous thread is still running ..."

@micstriit
Copy link
Copy Markdown
Contributor

In addition we should make a chage like this only for Lucee 5

@bdw429s
Copy link
Copy Markdown

bdw429s commented Dec 7, 2015

I would be in favor of adding an option to only allow a single instance of the task. I would say that is the most common expectation and I've had multiple issues where tasks run long and start to break things when more than one of them is running.

@micstriit
Copy link
Copy Markdown
Contributor

this is a setting from travis:
Limiting Concurrent Builds #
The maximum number of concurrent builds depends on the total system load, but one situation in which you might want to set a particular limit is:
if your build depends on an external resource and might run into a race condition with concurrent builds.
You can set the maximum number of concurrent builds in the settings pane for each repository.

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Oct 22, 2019

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants