Skip to content

Comments

SteamApiException's status code exposure#53

Merged
lpradel merged 6 commits intolpradel:masterfrom
Fugasss:steam-api-exception-status-code-exposure
Aug 31, 2025
Merged

SteamApiException's status code exposure#53
lpradel merged 6 commits intolpradel:masterfrom
Fugasss:steam-api-exception-status-code-exposure

Conversation

@Fugasss
Copy link
Contributor

@Fugasss Fugasss commented May 23, 2025

Added exposure of a status code to make it possible to handle it in a required way.

Fugasss added 2 commits May 22, 2025 17:44
- statusCode exposed
- throws 400 status code by default
Fugasss added 3 commits July 19, 2025 19:37
…-exposure

# Conflicts:
#	src/main/java/com/lukaspradel/steamapi/core/exception/SteamApiException.java
#	src/main/java/com/lukaspradel/steamapi/core/exception/SteamApiKeyException.java
B
Updated SteamApiException
@Fugasss
Copy link
Contributor Author

Fugasss commented Jul 19, 2025

@lpradel I don't like the way it all works now.
In fact, cause and statusCode are now absolutely identical indicators and, ideally, it would be better to get rid of one of them when passing to the constructor.
What do you think?

@coveralls
Copy link
Collaborator

coveralls commented Jul 31, 2025

Coverage Status

coverage: 97.073% (-0.5%) from 97.541%
when pulling 05c79b8 on Fugasss:steam-api-exception-status-code-exposure
into 8b8b573 on lpradel:master.

@lpradel
Copy link
Owner

lpradel commented Aug 3, 2025

@Fugasss I have removed the cause field from SteamApiException entirely (see latest commit ). Please take a look and see if it now aligns with what you intended.

@Fugasss
Copy link
Contributor Author

Fugasss commented Aug 30, 2025

@lpradel Everything works great now, thanks!

@lpradel lpradel merged commit 06eb0d3 into lpradel:master Aug 31, 2025
2 checks passed
@lpradel
Copy link
Owner

lpradel commented Aug 31, 2025

@Fugasss I have created new release version 1.12.0 it should be on mvn central within 24 hours. Thanks a lot for your contribution 🥳 if it's alright with you I will add you to contributors in README.md

@Fugasss
Copy link
Contributor Author

Fugasss commented Aug 31, 2025

@lpradel Nice!
You can add me to contributors if you want, I would be glad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants