Implement TF2 GetPlayerItems

[MihajloNesic]

I needed TF2 items so I Implemented IEconItems_440/GetPlayerItems

https://wiki.teamfortress.com/wiki/WebAPI/GetPlayerItems

[MihajloNesic]

Also, I had hard time setting local dev environment. You might want to revisit that section (if you want and have free time) :)

[lpradel]

@MihajloNesic Thanks a lot for your contribution! I will try to review more in-depth asap.

[coveralls]

coverage: 97.747% (-0.06%) from 97.809%
when pulling a031c61 on MihajloNesic:feature/tf2-player-items
into 7f77abf on lpradel:master.

[lpradel]

I think where not actually needed we should use integer over number which gets mapped to Long instead of Double for better performance (see https://github.com/lpradel/steam-web-api-java/blob/master/pom.xml#L149 ). Hope you agree?

[lpradel]

@MihajloNesic also could you maybe explain in a little more detail what exactly gave you trouble getting it to build locally? What issues did you run into? Would very much like to add an info section about this as you suggested!

[MihajloNesic]

@MihajloNesic also could you maybe explain in a little more detail what exactly gave you trouble getting it to build locally? What issues did you run into? Would very much like to add an info section about this as you suggested!

I couldn't get the test suite to work. Maybe it was just me cause I have some 'weird' maven profiles setup.

Try to setup a clean env on your machine (or vm or container) and try it out. If it doesn't give you troubles, then please ignore my request :)

[lpradel]

@MihajloNesic also could you maybe explain in a little more detail what exactly gave you trouble getting it to build locally? What issues did you run into? Would very much like to add an info section about this as you suggested!

I couldn't get the test suite to work. Maybe it was just me cause I have some 'weird' maven profiles setup.

Try to setup a clean env on your machine (or vm or container) and try it out. If it doesn't give you troubles, then please ignore my request :)

Hmmm interesting 🤔 I will give it a try, however I would assume that the Github workflow builds should be similar to clean environment. Can you recall the errors / logs you got?

[lpradel]

@MihajloNesic Also one more small thing. Due to considerable work you put into this change I think it is more than deserved that you are mentioned among contributors here: https://github.com/lpradel/steam-web-api-java/blob/master/README.md?plain=1#L237
Feel free to add yourself or I will do it for you.

Again thanks a lot for this!

[MihajloNesic]

Hmmm interesting 🤔 I will give it a try, however I would assume that the Github workflow builds should be similar to clean environment. Can you recall the errors / logs you got?

I got this when trying to run the test (using Java 11)

java.lang.reflect.InaccessibleObjectException: Unable to make public void com.lukaspradel.steamapi.BaseTest.initMocks() accessible: module com.lukaspradel.steamapi does not "exports com.lukaspradel.steamapi" to unnamed module @44c2862d

The way I tested the app was building the jar and trying it out on a mini-project.

[MihajloNesic]

@MihajloNesic Also one more small thing. Due to considerable work you put into this change I think it is more than deserved that you are mentioned among contributors here: https://github.com/lpradel/steam-web-api-java/blob/master/README.md?plain=1#L237 Feel free to add yourself or I will do it for you.

Again thanks a lot for this!

Cheers 🎉

[lpradel]

@MihajloNesic I have made a new release 1.10.0 with the new interface should be available on Maven central within the next 24 hours. Thanks!

[lpradel]

@MihajloNesic also could you maybe explain in a little more detail what exactly gave you trouble getting it to build locally? What issues did you run into? Would very much like to add an info section about this as you suggested!

I couldn't get the test suite to work. Maybe it was just me cause I have some 'weird' maven profiles setup.

Try to setup a clean env on your machine (or vm or container) and try it out. If it doesn't give you troubles, then please ignore my request :)

@MihajloNesic I hope that I have fixed the issue, could you give it a try with the most recent main branch?

[MihajloNesic]

@lpradel Awesome, works now. Thanks :)