Skip to content

Comments

Add support for /ISteamApps/GetAppList/v0002/#22

Merged
lpradel merged 4 commits intolpradel:masterfrom
josephbleau:feature-GetAppList
Aug 2, 2023
Merged

Add support for /ISteamApps/GetAppList/v0002/#22
lpradel merged 4 commits intolpradel:masterfrom
josephbleau:feature-GetAppList

Conversation

@josephbleau
Copy link
Contributor

Hello! Thanks for the really easy to use and extend API library! :)

Change Description

This small change adds support for the GetAppList API call.

This API is useful for applications that want to interact with other APIs such as GetAppDetails, where an AppID is expected.

@lpradel lpradel self-assigned this May 28, 2023
@lpradel
Copy link
Owner

lpradel commented May 30, 2023

Hi Joey,

thanks a lot for your contribution! I'm leaving for vacation today so unfortunately I can't review this in time anymore. Promise to look at it when I get back middle of June. Once again, thanks for your patience.

@josephbleau
Copy link
Contributor Author

No worries, it is of extremely low importance. Enjoy your trip!

@lpradel
Copy link
Owner

lpradel commented Jun 14, 2023

@josephbleau Overall your changes are good, thanks! However there's a few bits and pieces missing (mostly tests) before I can integrate your changes. I have prepared the additional changes in the branch of your fork. Could you grant me permission to push changes into the branch of your fork? If you are not sure how, here is the doc

@lpradel lpradel force-pushed the feature-GetAppList branch from eaab023 to 1aeb7f2 Compare June 14, 2023 21:12
@lpradel
Copy link
Owner

lpradel commented Jun 14, 2023

Actually never mind that it seems it was enabled by default. Please review the changes I amended to your original PR:

@lpradel lpradel force-pushed the feature-GetAppList branch from 1aeb7f2 to 05078b7 Compare June 14, 2023 21:14
@lpradel
Copy link
Owner

lpradel commented Aug 2, 2023

Well at this point I'm going to go ahead and assume that @josephbleau is more or less fine with my additions 😅

@lpradel
Copy link
Owner

lpradel commented Aug 2, 2023

I also took the liberty of adding you as contributor hope that's ok with you as well

@lpradel lpradel merged commit eebfed4 into lpradel:master Aug 2, 2023
@lpradel
Copy link
Owner

lpradel commented Aug 2, 2023

I will release as 1.6.0 ASAP thanks for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants