Upgrade to httpclient5#13
Merged
lpradel merged 6 commits intolpradel:masterfrom Jul 19, 2022
41zu:upgrade-to-httpclient5
Merged
Upgrade to httpclient5#13lpradel merged 6 commits intolpradel:masterfrom 41zu:upgrade-to-httpclient5
lpradel merged 6 commits intolpradel:masterfrom
41zu:upgrade-to-httpclient5
Conversation
Owner
|
I just got back from vacation, will take a look soon! |
Contributor
Author
|
Ok, |
lpradel
approved these changes
Jul 18, 2022
Owner
lpradel
left a comment
lpradel
left a comment
There was a problem hiding this comment.
This looks good to me as well tested it as well and works. Could you please rebase master into your feature branch? I tried to fix the annoying issue with GH action failing on pull requests
Contributor
Author
|
Done. Had also to do a commit to retrigger the CI |
Owner
|
@41zu Just released 1.4 to Maven central should be available in 1-2 days. |
Contributor
Author
|
@lpradel Ok, thank you :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi again,
I reworked the code and now all tests are passing. I also tested it in my personal Java project and even on Android (here is a screenshot https://www.dropbox.com/s/0twizzfz6xvpymd/2022-07-05_12-57.png?dl=0).
I would be delighted if you could merge the code and maybe release version 1.4 on maven central ;)
Thank you in advance