fix(build): use tslint.build.json as the base#964
Merged
raymondfeng merged 1 commit intomasterfrom Feb 5, 2018
Merged
Conversation
dacfde2 to
8cc3d73
Compare
shimks
approved these changes
Feb 5, 2018
virkt25
approved these changes
Feb 5, 2018
Contributor
virkt25
left a comment
There was a problem hiding this comment.
Looks great! Just need to disable the rule in example-getting-started so it doesn't fail on CI.
The regression is caused by 15dd2db
8cc3d73 to
ad9ecd5
Compare
Contributor
Author
|
Adding |
b-admike
approved these changes
Feb 5, 2018
Member
And creates another regression - the VSCode plugin for tslint report even more warnings now: We need to discuss this in more depth to find a solution that will work for both |
Member
|
Ideally, we should use TypeScript's |
raymondfeng
added a commit
that referenced
this pull request
Feb 6, 2018
This is a follow-up to #964. Two config files are in place now: - tslint.build.json for CLI build scripts - tslint.json for vscode
6 tasks
raymondfeng
added a commit
that referenced
this pull request
Feb 6, 2018
This is a follow-up to #964. Two config files are in place now: - tslint.build.json for CLI build scripts - tslint.json for vscode
raymondfeng
added a commit
that referenced
this pull request
Feb 6, 2018
This is a follow-up to #964. Two config files are in place now: - tslint.build.json for CLI build scripts - tslint.json for vscode
6 tasks
raymondfeng
added a commit
that referenced
this pull request
Feb 8, 2018
This is a follow-up to #964. Two config files are in place now: - tslint.build.json for CLI build scripts - tslint.json for vscode
raymondfeng
added a commit
that referenced
this pull request
Feb 8, 2018
This is a follow-up to #964. Two config files are in place now: - tslint.build.json for CLI build scripts - tslint.json for vscode
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a regression from 15dd2db
Checklist
npm testpasses on your machinepackages/cliwere updatedpackages/example-*were updated