docs: simplify middleware-based sequence#6824
Conversation
This comment has been minimized.
This comment has been minimized.
07f7650 to
43a01a6
Compare
This comment has been minimized.
This comment has been minimized.
|
@mrmodise Thank you for the PR. For sequences, we basically have two styles:
Both sequence are extensible and customizable. The legacy sequence has a middleware action that allows plugging in additional middleware. The new sequence is fully composable from middleware via the extension point/extension pattern. Each style has a base class to be extended for customization. |
|
Thanks @raymondfeng based on your comments I think even the action-based sequence needs some improvement since the section is mixing a lot of complex topics. Let me do some optimisations there as well. You can review the current changes on middleware-based since thats the one I had targeted |
43a01a6 to
d2b831a
Compare
738dae1 to
4d1ad7e
Compare
dhmlau
left a comment
There was a problem hiding this comment.
@mrmodise, thanks for the PR. I had some minor comments.
For the files to be deleted, I'm wondering if there's an equivalent file for that. If yes, it would be helpful to add redirect_from in the front matter of the md file (example: https://raw.githubusercontent.com/strongloop/loopback-next/master/docs/site/Accessing-services.md). Thanks.
4d1ad7e to
ddda96d
Compare
I will double check this |
c134140 to
3ebe64c
Compare
307d543 to
9e936d1
Compare
achrinza
left a comment
There was a problem hiding this comment.
Great work thus far! 👍
Sorry I don't have time to fully look through the changes in detail. But this is my initial comments 👇
Signed-off-by: mrmodise <modisemorebodi@gmail.com>
9e936d1 to
6ab15cc
Compare
For the pages to be deleted i split the content across other pages PTAL @dhmlau |
I reviewed the new version, no pages are being removed now. Existing links pointing to our docs should keep working after this change. |
|
Landed, thank you @mrmodise for the contribution! ❤️ |
Closes #6770
Checklist
npm testpasses on your machinepackages/cliwere updatedexamples/*were updated👉 Check out how to submit a PR 👈