build: drop multiple dist targets, always use es2017#1803
Merged
Conversation
503069e to
ba4bb84
Compare
7 tasks
Member
Author
|
Grr. Apparently |
ba4bb84 to
6e6de52
Compare
5cfb7e9 to
1f36d7b
Compare
1f36d7b to
cffa630
Compare
Member
Author
|
Uff, we have so many places affected by the design decision to support multiple dist targets! I hope that I found them all, unfortunately it makes the change-set huge. The pull request is ready for review. |
raymondfeng
approved these changes
Oct 4, 2018
Contributor
raymondfeng
left a comment
There was a problem hiding this comment.
👍 Thank you for the effort!
marioestradarosa
approved these changes
Oct 4, 2018
Contributor
marioestradarosa
left a comment
There was a problem hiding this comment.
👍 Excellent @bajtos !
This was referenced Oct 5, 2018
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on the work in #1636, it's clear that we cannot continue building for multiple ES targets (ES2017 for Node.js 8.x and ES2018 for Node.js 10.x) if we want to use TypeScript Project References. (And we do want to!)
This pull request is removing multi-dist build and switching all packages (including project templates) to always build for ES2017 (Node.js 8.x) only.
dist10is removed completelydist8is moved todistbuild:dist8,build:dist10andbuild:dist-allscripts are removed in favor ofbuild:distlb-mocha'sDISTtemplate, usedistinstead@loopback/dist-util, load./distdirectly. Keep using@loopback/dist-utilinside CLI - we need the version checkcompile-packageto correctly treat--outDirpath as relative to CWD