lkl: Support json configuration and multiple interfaces #385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
tavip
reviewed
Oct 17, 2017
tools/lkl/tests/hijack-test.sh
Outdated
|
|
||
| echo "== Mount/dump tests ==" | ||
| cfgjson=${work_dir}/hijack-test.conf | ||
| echo " {" \ |
Member
There was a problem hiding this comment.
Lets use <<EOF style indirection to avoid escaping " and make it more readable.
Author
There was a problem hiding this comment.
Thank you for your review.
I have fixed.
Member
|
@lkl-jenkins: test this please |
This change allows user to configure lkl with json file. This change still supports configuration using environment variable. Also allows lkl to have multiple interfaces. Reviewed-by: Hajime Tazaki <[email protected]> Signed-off-by: Motomu Utsumi <[email protected]>
motomuman
force-pushed
the
json-config
branch
2 times, most recently
from
3468aa6 to
0985842
Compare
tavip
approved these changes
Oct 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows user to configure lkl with json file.
This change still supports configuration using environment variable.
Also allows lkl to have multiple interfaces.
Reviewed-by: Hajime Tazaki [email protected]
Signed-off-by: Motomu Utsumi [email protected]
This change is