remove protobuf from the deps of examples #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
I am landing the PR now, and will try making a new release to see if the problems go away or not. If any of you has comments, I will make follow-up PRs to address them. Thanks |
xianshijing-lk
deleted the
sxian/CLT-2395/remove_protobuf_from_examples_deps
branch
xianshijing-lk
added a commit
that referenced
this pull request
Jan 7, 2026
This reverts commit 94bc274.
xianshijing-lk
added a commit
that referenced
this pull request
Jan 7, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should solve the issues of running the executables in the release zip file, take MacOS one as example:
./bin/SimpleRoom dyld[46441]: Library not loaded: /opt/homebrew/opt/protobuf/lib/libprotobuf.33.2.0.dylib Referenced from: <410C9860-6926-371A-A580-50A366AF5757> /Users/shijing/Downloads/livekit-sdk-macos-arm64-0.1.1/bin/SimpleRoom Reason: tried: '/opt/homebrew/opt/protobuf/lib/libprotobuf.33.2.0.dylib' (no such file), '/System/Volumes/Preboot/Cryptexes/OS/opt/homebrew/opt/protobuf/lib/libprotobuf.33.2.0.dylib' (no such file), '/opt/homebrew/opt/protobuf/lib/libprotobuf.33.2.0.dylib' (no such file), '/opt/homebrew/Cellar/protobuf/32.1/lib/libprotobuf.33.2.0.dylib' (no such file), '/System/Volumes/Preboot/Cryptexes/OS/opt/homebrew/Cellar/protobuf/32.1/lib/libprotobuf.33.2.0.dylib' (no such file), '/opt/homebrew/Cellar/protobuf/32.1/lib/libprotobuf.33.2.0.dylib' (no such file)