don't embed ansi escape codes in appkey#278
Merged
thespad merged 1 commit intolinuxserver:masterfrom Jan 4, 2026
Merged
Conversation
given that it's the recommended way to generate the code in the docs, redirecting stdout will produce an appkey that will make bookstack crash when it runs. this will affect anyone who is trying to automate the initial steps of deployment. i think this is likely the cause of this issue: BookStackApp/BookStack#5289 (comment)
There was a problem hiding this comment.
Thanks for opening this pull request! Be sure to follow the pull request template!
Collaborator
|
I am a bot, here is the pushed image/manifest for this PR:
|
Collaborator
|
I am a bot, here is the pushed image/manifest for this PR:
|
thespad
approved these changes
Jan 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
given that it's the recommended way to generate the code in the docs, redirecting stdout will produce an appkey that will make bookstack crash when it runs. this will affect anyone who is trying to automate the initial steps of deployment.
i think this is likely the cause of this issue: BookStackApp/BookStack#5289 (comment)
Description:
Benefits of this PR and context:
How Has This Been Tested?
Source / References: