Skip to content

fix: [UIE-10136] - Fix Open Re-direction vulnerability in Account Cancel flow.#13400

Open
tanushree-akamai wants to merge 3 commits intolinode:developfrom
tanushree-akamai:feature/UIE-10136-open-redirection-vuln
Open

fix: [UIE-10136] - Fix Open Re-direction vulnerability in Account Cancel flow.#13400
tanushree-akamai wants to merge 3 commits intolinode:developfrom
tanushree-akamai:feature/UIE-10136-open-redirection-vuln

Conversation

@tanushree-akamai
Copy link
Contributor

Description 📝

Fix Open Redirect Vulnerability in Account Cancellation.

Changes 🔄

  • Implement CRUD MSW mocks for account/close endpoint
  • Eliminate survey link data exposure via query parameters
  • Secure data by passing through router state instead

Scope 🚢

Upon production release, changes in this PR will be visible to:

  • All customers
  • Some customers (e.g. in Beta or Limited Availability)
  • No customers / Not applicable

Target release date 🗓️

Feb 2026

Preview 📷

Before After
Screenshot 2026-02-13 at 9 05 18 PM Screenshot 2026-02-13 at 9 02 36 PM

https://github.com/user-attachments/assets/c26d6ba6-f7f8-4f6a-8cb7-c2d627c801f7
Attached Video with steps to verify the issue.

How to test 🧪

Prerequisites

  • Open DevTools Panel
  • In DevTools Panel, enable CRUD MSW
  • Navigate to "User Permissions" section
  • Select "Custom User Account Permissions"
  • Click "Edit" to modify permissions
  • Update the permissions array to include lock permissions:
    [ "view_account_settings", "cancel_account" ]

Verification steps

  • Click the Account link in the sidebar.
  • Click the Account settings option
  • Under the Close Account panel, click the Close Account button.
  • A confirmation form appears. Enter your Linode username in the first field and optionally enter any comments you'd like to leave in the second field
  • Click the Close Account button to complete your account cancellation.
  • Observe there are no queryParams in the URL
  • Click on Take this survey, it navigates to a mock url.
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All tests and CI checks are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@tanushree-akamai tanushree-akamai self-assigned this Feb 13, 2026
@tanushree-akamai tanushree-akamai requested a review from a team as a code owner February 13, 2026 16:02
@tanushree-akamai tanushree-akamai added the Security Pull requests that address a security vulnerability label Feb 13, 2026
@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🔺 1 failing test on test run #3 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
1 Failing865 Passing11 Skipped41m 55s

Details

Failing Tests
SpecTest
vpc-details-page.spec.tsCloud Manager Cypress Tests→VPC details page » can create, edit, and delete a subnet from the VPC details page

Troubleshooting

Use this command to re-run the failing tests:

pnpm cy:run -s "cypress/e2e/core/vpc/vpc-details-page.spec.ts"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ready for Review Security Pull requests that address a security vulnerability

Projects

Status: Review

Development

Successfully merging this pull request may close these issues.

3 participants