-
Notifications
You must be signed in to change notification settings - Fork 397
upcoming: [UIE-9648] - Support Placement Group Policy Update in line with Placement Group Aware Maintenance program #13351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
…t-group Aware Maintenance program
…lacement Group Aware Maintenance program
dwiley-akamai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verification steps ✅
Code review ✅
Approved pending resolution of code conflict
| export const useIsPlacementGroupPolicyUpdated = () => { | ||
| const flags = useFlags(); | ||
|
|
||
| // @TODO NB-VPC: check for customer tag/account capability when it exists |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does this relate to NB-VPC?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops. That seems like an unintentional copy-paste error. Thanks for pointing it out!
| * TODO: Clean up this flag after the Placement Group Policy Update is complete. | ||
| */ | ||
|
|
||
| export const useIsPlacementGroupPolicyUpdated = () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Optional: This wrapper may be unnecessary. Maybe we just use flags.placementGroupPolicyUpdate throughout the app
Cloud Manager UI test results🎉 866 passing tests on test run #6 ↗︎
|
Description 📝
The Placement Group's Strict and Flexible policy have been updated as a part of the PAM program.
Changes 🔄
placementGroupPolicyUpdatefeature flagScope 🚢
Upon production release, changes in this PR will be visible to:
Preview 📷
How to test 🧪
Verification steps
Placement Group Policy Updateflag in dev toolsAuthor Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅