upcoming: [UIE-9461] IAM Parent/Child - server side filter on Switch Account Drawer#13318
Conversation
5af6080 to
97b69c1
Compare
| ? errors.allChildAccountsError | ||
| : errors.childAccountInfiniteError; | ||
|
|
||
| if (hasError) { |
There was a problem hiding this comment.
Moved this to the SwitchAccountDrawer component since it’s needed for both the List and Table.
d1e9d05 to
aa9e511
Compare
| onPageSizeChange={( | ||
| e: CustomEvent<{ page: number; pageSize: number }> | ||
| ) => handlePageSizeChange(Number(e.detail.pageSize))} | ||
| page={page} |
There was a problem hiding this comment.
@bnussman-akamai , I have a question about pagination from usePaginationV2:
we use a table inside the drawer, and with usePaginationV2 we need to provide a currentRoute. That’s not straightforward in this case because it’s a user menu. I tried using location and useMatch, but it didn’t help. Is there a way to use it here?
I’d appreciate any suggestions!
There was a problem hiding this comment.
Hmm. I'm wondering if currentRoute is even necessary. We could make currentRoute optional in usePaginationV2 and that would just cause usePaginationV2 to stay on the same route.
But if we did that, we then would have to deal with query params lingering after the Switch Account drawer is closed and weird stuff like that.
In this case, using state for page and pageSize like this PR does might be the best solution because using query params for a drawer might not be desired in the first place
Cloud Manager UI test results🎉 866 passing tests on test run #10 ↗︎
|
…tch Account drawer
aa9e511 to
ca74235
Compare
packages/manager/src/features/Account/SwitchAccounts/ChildAccountsTable.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/Account/SwitchAccounts/ChildAccountsTable.tsx
Show resolved
Hide resolved
aaleksee-akamai
left a comment
There was a problem hiding this comment.
looks good, thanks!
cf328d1 to
81a80ed
Compare
81a80ed to
66d99c1
Compare
Description 📝
This PR added server side filtering for Switch Account drawer
Changes 🔄
List any change(s) relevant to the reviewer.
akamai-cds-react-components.Scope 🚢
Upon production release, changes in this PR will be visible to:
How to test 🧪
Prerequisites
(How to setup test environment)
Verification steps
(How to verify changes)
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅