Align GHA workflows in the scope of report uploads#642
Open
mawilk90 wants to merge 3 commits intolinode:devfrom
Open
Align GHA workflows in the scope of report uploads#642mawilk90 wants to merge 3 commits intolinode:devfrom
mawilk90 wants to merge 3 commits intolinode:devfrom
Conversation
mawilk90
added
the
improvement
mawilk90
requested review from
ezilber-akamai and
lgarber-akamai
and removed request for
a team
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an opt-in workflow_dispatch input to control whether E2E test reports are uploaded, preventing automatic uploads on manually triggered runs unless explicitly requested.
Changes:
- Introduces a
test_report_uploadinput (defaultfalse) for manual workflow runs. - Updates conditional logic for uploading test reports to only run on push/PR events by default, or when explicitly enabled for
workflow_dispatch.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| .github/workflows/e2e-test.yml | Adds test_report_upload input and gates the report upload job for manual runs. |
| .github/workflows/e2e-test-pr.yml | Adds test_report_upload input and gates the “Upload test results” step for manual runs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mawilk90
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
GHA workflows upload test results to TOD on push, PR and manual (workflow_dispatch) runs. PR covers aligning integration test workflows to upload results automatically on push/PR and on demand for manual runs.
https://track.akamai.com/jira/browse/TPT-4190
✔️ How to Test
Manual run of the workflow should not upload test results to TOD by default.